Code Quality Checks #157
Open
Code Quality Checks #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for open sourcing this wonderful project. I want to make a code quality control contribution. As your project is growing, I've noticed that it's becoming essential to add this type of control so that new contributors can find the code easier to read in the future and eventually contribute to it.
This pull request includes a Makefile that checks the quality of the code with make quality and reformats the code with make style. It's using the Ruff library as a formatter. I have already run it on the repository, and it did fix some inconsistencies, but there are more to address. I'm waiting for your opinion to continue the work on it.
I'm also considering adding a PR workflow that checks new pull requests to ensure they meet the quality standards before merging them. What do you think?