Skip to content

chore(test): Adopt Gherkin-style notation for DataIngestorTest readability#6

Merged
impatient0 merged 1 commit intodevelopfrom
chore/update-test-notation
Nov 3, 2025
Merged

chore(test): Adopt Gherkin-style notation for DataIngestorTest readability#6
impatient0 merged 1 commit intodevelopfrom
chore/update-test-notation

Conversation

@impatient0
Copy link
Owner

Summary

This pull request refactors the test structure and naming conventions within DataIngestorTest to adopt the Gherkin-style notation (Given/When/Then), aligning it with the pattern established in the BacktestEngineTest class.

Key Changes

  • Test Structure: Introduces a top-level @Nested class with a GIVEN block (GIVEN DataIngestor is configured to fetch Klines data) to group related tests.
  • Readability: Updates individual @DisplayName annotations for test methods to follow the WHEN... THEN... structure, significantly improving the clarity of the test specification.
  • Scope: This is a purely cosmetic and structural refactoring of the test class. No changes have been made to the underlying test logic, assertions, or production code, ensuring full backward compatibility and correctness.

This change promotes a unified and highly readable test standard across the project.

- Wrap the tests in a `@Nested` test class
- Rewrite test names to utilize Gherkin-style notation
@impatient0 impatient0 merged commit 60d7bc6 into develop Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant