Make eco recognize podTemplate changes#196
Open
gottwald wants to merge 2 commits intoimprobable-eng:masterfrom
Open
Make eco recognize podTemplate changes#196gottwald wants to merge 2 commits intoimprobable-eng:masterfrom
gottwald wants to merge 2 commits intoimprobable-eng:masterfrom
Conversation
Changes are handled like version upgrades with a rolling re-deployment cycle of all etcd members.
| if peer, reason := nextOutdatedPeer(cluster, peers); peer != nil { | ||
| if reason == outdatedVersion { | ||
| if peer.Spec.Version == cluster.Spec.Version { | ||
| log.Info("Waiting for EtcdPeer to report expected server version", "etcdpeer-name", peer.Name) |
Contributor
There was a problem hiding this comment.
Maybe put a comment here to elaborate. Just something to explain that this branch occurs when we've updated the Pod specification but the etcd peer still shows as outdated.
|
|
||
| const ( | ||
| outdatedVersion outdatedReason = iota + 1 | ||
| outdatedPodTemplate |
Contributor
There was a problem hiding this comment.
Is this using the defaulting to infer a type of outdatedReason and a value of 0?
Author
There was a problem hiding this comment.
Not sure I fully understand your question. This is just to have a constant to differentiate between the different outdated reasons. The enumeration starts with 1 on purpose so that a possible use of a default value (0) doesn't accidentally signal a specific reason where there is none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cycle of all etcd members.
Verification
Refs #109 (but solved in a more generic way)