Fix #33: Support asm labels on register variables #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `asm` attributes on `register` variables by allowing `asm` and `attributes` to be added to `TypeDeclExt` and `ArrayDeclExt` nodes.
This was preventing the parser from attaching `asm` labels to declarations with storage-class specifiers like `register`.
A new test case, `test_register_asm_label`, is added to verify that declarations like `register int my_var asm("my_reg");` are now parsed correctly.
This commit enhances the test_register_asm_label test to include round-trip testing, which was the main issue reported in inducer#33. The original issue stated: 'when I convert it back to C-Code then no C-Code is created for this line.' This fix adds: - Round-trip test for basic asm syntax - Round-trip test for __asm__ variant - Round-trip test for different type specifiers All tests verify that parsing and code generation work correctly.
- Change single quotes to double quotes in __slots__ declarations - Fix import ordering (pycparser before pycparserext) - Standardize quote style in test assertions
Owner
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Adds support for parsing GNU C extension syntax: