agent: return error when cert auth fails#22
Open
zimbabao wants to merge 1 commit intoindutny:masterfrom
Open
Conversation
Sites without intermediate certs in chain and other ssl error ends up with sockets.ssl being null and that causes Type error in agent.
zimbabao
force-pushed
the
handle-ssl-authorization-error
branch
from
84d1b1a to
ac936b1
Compare
|
@indutny It seems like this project has been abandoned, but my organization has been using it for the last couple of years. This issue is preventing us from a new release of one of our products. If the lint errors are fixed, could we get this merged and a patch release out? If not, we can fork the project and fix it up ourselves, but I would rather continue to use and contribute to the original, open source version here if possible. |
Owner
|
@dawsonc623 could you send me an email (it is my github profile). I'd be happy to discuss this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sites without intermediate certs in chain
and other ssl error ends up with sockets.ssl
being null and that causes Type error in agent.