Open
Conversation
6a399b3 to
3281524
Compare
Author
|
Travis reports one failing test, but I don't think it should block this PR because it also fails on |
439ea0a to
dbb51d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into an error that's crashed our monitoring service. In short, when trying to check an https service which runs an expired certificate, nodejs doesn't create
socket.ssl(at least in node v13), and thusoscpproceeds to throw an error. In our case, we're using thehttpsmodule withocsp'sAgent, which produces the following error:This can be fixed by moving the relevant code into the
try/catchstatement that already exists inAgent.prototype.handleOCSPResponse, which then allowshttpsto display the actual error properly: