Fix PipeWire audio build errors (v25.1.1)#68
Merged
infinityabundance merged 3 commits intomainfrom Feb 14, 2026
Merged
Conversation
Fixed incorrect usage of SPA_AUDIO_INFO_RAW_INIT macro in both audio_capture_pipewire.c and audio_playback_pipewire.c. The macro should be used inline as an argument to spa_format_audio_raw_build() rather than as a variable initialization. This aligns with PipeWire's official examples and prevents potential build errors with different compiler settings or PipeWire versions. Co-authored-by: infinityabundance <255699974+infinityabundance@users.noreply.github.com>
Co-authored-by: infinityabundance <255699974+infinityabundance@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build errors in PipeWire audio files
Fix PipeWire audio build errors (v25.1.1)
Feb 14, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed incorrect
SPA_AUDIO_INFO_RAW_INITmacro usage in PipeWire audio backend causing build errors with certain compiler configurations.Details
What changed?
src/audio_capture_pipewire.c: InlineSPA_AUDIO_INFO_RAW_INITusagesrc/audio_playback_pipewire.c: InlineSPA_AUDIO_INFO_RAW_INITusageBefore:
After:
Rationale
Testing
make)Validation:
-Wall -Wextra -WerrorNotes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.