Skip to content

Fix PipeWire audio build errors (v25.1.1)#68

Merged
infinityabundance merged 3 commits intomainfrom
copilot/fix-pipewire-audio-build-errors
Feb 14, 2026
Merged

Fix PipeWire audio build errors (v25.1.1)#68
infinityabundance merged 3 commits intomainfrom
copilot/fix-pipewire-audio-build-errors

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

Summary

Fixed incorrect SPA_AUDIO_INFO_RAW_INIT macro usage in PipeWire audio backend causing build errors with certain compiler configurations.

Details

  • Bug fix
  • New feature
  • Performance improvement
  • Documentation / tooling

What changed?

  • src/audio_capture_pipewire.c: Inline SPA_AUDIO_INFO_RAW_INIT usage
  • src/audio_playback_pipewire.c: Inline SPA_AUDIO_INFO_RAW_INIT usage

Before:

struct spa_audio_info_raw info = SPA_AUDIO_INFO_RAW_INIT(
    .format = SPA_AUDIO_FORMAT_S16,
    .channels = pw->channels,
    .rate = pw->sample_rate
);
params[0] = spa_format_audio_raw_build(&b, SPA_PARAM_EnumFormat, &info);

After:

params[0] = spa_format_audio_raw_build(&b, SPA_PARAM_EnumFormat, 
    &SPA_AUDIO_INFO_RAW_INIT(
        .format = SPA_AUDIO_FORMAT_S16,
        .channels = pw->channels,
        .rate = pw->sample_rate
    ));

Rationale

  • Macro designed for inline use per PipeWire examples
  • Variable initialization pattern triggers C99 designated initializer issues with some compilers
  • Eliminates unnecessary intermediate allocation

Testing

  • Built successfully (make)
  • Basic streaming tested
  • Tested on:
    • Distro: Ubuntu 24.04
    • Kernel: N/A (syntax validation only)
    • GPU & driver: N/A

Validation:

  • GCC syntax check with -Wall -Wextra -Werror
  • Code review: no issues
  • CodeQL: no applicable changes

Notes

  • Potential impact on latency or resource usage: None (zero functional change)
  • Any follow-up work needed: None (addresses deferred Phase 25 build issues)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 14, 2026 15:46
Fixed incorrect usage of SPA_AUDIO_INFO_RAW_INIT macro in both
audio_capture_pipewire.c and audio_playback_pipewire.c. The macro
should be used inline as an argument to spa_format_audio_raw_build()
rather than as a variable initialization.

This aligns with PipeWire's official examples and prevents potential
build errors with different compiler settings or PipeWire versions.

Co-authored-by: infinityabundance <255699974+infinityabundance@users.noreply.github.com>
Co-authored-by: infinityabundance <255699974+infinityabundance@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build errors in PipeWire audio files Fix PipeWire audio build errors (v25.1.1) Feb 14, 2026
@infinityabundance infinityabundance marked this pull request as ready for review February 14, 2026 15:55
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@infinityabundance infinityabundance merged commit 9a6b657 into main Feb 14, 2026
1 of 6 checks passed
@infinityabundance infinityabundance deleted the copilot/fix-pipewire-audio-build-errors branch February 19, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants