Skip to content

Add retries to outbox on confirm failure #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bruno-DaSilva wants to merge 1 commit into
base: outbox
Choose a base branch
from
Open

Add retries to outbox on confirm failure #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/multiple_man/producers/general.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,20 @@ def send_messages!(grouped_messages, connection)
def confirm_published!(messages, connection)
ActiveSupport::Notifications.instrument('multiple_man.producer.confirm_published') do
channel = connection.channel
raise ProducerError.new(channel.nacked_set.to_a) unless channel.wait_for_confirms

MultipleMan.logger.debug("published #{messages.size} messages")
begin
retries ||= 3
raise ProducerError.new(channel.nacked_set.to_a) unless channel.wait_for_confirms
rescue ProducerError
if (retries -= 1).zero?
MultipleMan.logger.debug("Tried to publish #{messages.size}, but failed to publish #{channel.nacked_set.size} messages!")
break
end
grouped_messages = group_by_set(messages)
send_messages!(grouped_messages, connection)
retry
else
MultipleMan.logger.debug("published #{messages.size} messages")
end
end
end

Expand Down