FEATURE: Added google chrome renderer to the plugin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an additional PDF renderer alongside the existing
SnappyPdfintegration. The new renderer uses Google Chrome in headless mode to convert prepared HTML files into PDFs. This approach leverages the latest advancements in CSS and JavaScript rendering, allowing for more modern and dynamic layouts compared to the legacywkhtmltopdftool.Due to the broad surface area for potential exploits and Chrome’s full-featured rendering engine, this feature is marked experimental. Use with caution in untrusted environments or consider sandboxing when handling user-supplied HTML.
Why:
wkhtmltopdfis no longer actively maintained and lacks support for modern web standards. This Chrome-based solution offers a future-proof and standards-compliant alternative, without sacrificing output quality or flexibility.