Ensure selection of fallback instance type if necessary#244
Open
konstantinbest wants to merge 1 commit intomasterfrom
Open
Ensure selection of fallback instance type if necessary#244konstantinbest wants to merge 1 commit intomasterfrom
konstantinbest wants to merge 1 commit intomasterfrom
Conversation
v0devil
requested changes
Feb 1, 2023
| """ | ||
|
|
||
| vm_types_overview = self.aws_get_instances_overview() | ||
| if vm_types_overview: |
Member
There was a problem hiding this comment.
Seems aws_get_instances_overview can return None, and then there is iteration aws_get_fitting_vm_types through overview var which can be None and then probably lead to TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may happen that we cannot find an instance type for a VM because the load values are too low. In this case, the build would simply stop. This change ensures that we always have at least the fallback instance type when installing.