WIP: Migration log: reduce number of entries and use microtime to avoid chances of conflicts#259
Open
WIP: Migration log: reduce number of entries and use microtime to avoid chances of conflicts#259
Conversation
…ances of duplicates
4523fc8 to
711e53e
Compare
TuxPowered42
requested changes
Oct 11, 2023
| src_hv = self.vm.hypervisor.dataset_obj['hostname'] | ||
| cpu_usage_vm_src = self.vm.hypervisor.estimate_vm_cpu_usage(self.vm) | ||
| timestamp = 1234567890 | ||
| timestamp = 1234567890000 |
Contributor
There was a problem hiding this comment.
Shouldn't this test timestamp be updated to the new format too, in case we ever restrict in Serveradmin?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got some very rare errors during
igvm migratewhen two migrations of the same source hypervisor finished at the same second with the same CPU value:Note:
\A([0-9]{10}|\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d+)\s[-|+][0-9]{1,3}\Z