Skip to content

Conversation

@bob8677
Copy link

@bob8677 bob8677 commented Apr 10, 2021

I removed the commented out grayscale part - did not seem to be used

maybe change the iconf name - I'm not sure and just chose something as a example

@paperbenni
Copy link
Member

If we're going to implement choosing different effects then why not keep the option of making it black and white and give it an iconf value?
The iconf name is fine btw 👍

@bob8677
Copy link
Author

bob8677 commented Apr 11, 2021

I rewrote it to allow for more options and added a bunch. Some might not be wanted, not sure.

Force pushing was to remove commits fixing codacy issues.

@bob8677 bob8677 marked this pull request as ready for review April 29, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants