⚡ Bolt: Cache XftDraw in Drw struct #168
Conversation
drw_text is called frequently for drawing text (window titles, status bar). Previously, it created and destroyed an XftDraw object on every call. This commit caches the XftDraw object in the Drw struct, initializing it in drw_create and updating it in drw_resize. This reduces X server round-trips and memory allocation overhead during rendering.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
⚡ Bolt Performance Improvement
💡 What:
Cached the
XftDrawcontext within theDrwstruct instead of creating and destroying it on every call todrw_text.🎯 Why:
drw_textis a hot path, called for every window title, tag, and status bar element during every redraw. Repeatedly callingXftDrawCreateandXftDrawDestroyinvolves unnecessary memory allocation and potential X server overhead.📊 Impact:
Reduces overhead in the main rendering loop. While exact micro-benchmarks are difficult without an X11 profiling setup, avoiding repeated allocations in a hot loop is a standard optimization practice in C graphics programming.
🔬 Measurement:
Verified via code inspection and build verification. The logic ensures
XftDrawlifecycle matches thedrawable(pixmap) lifecycle.PR created automatically by Jules for task 13421265876079189192 started by @paperbenni