⚡ Bolt: Optimize drw_map by replacing XSync with XFlush #173
Conversation
Replaced XSync with XFlush in drw_map to reduce blocking round-trips to the X server. This significantly improves performance during frequent redraws (e.g., status bar updates) by making the drawing non-blocking. XSync waits for the X server to process the request, which is unnecessary for simple drawing operations where order is guaranteed by the protocol. Added inline comment explaining the optimization.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
💡 What: Replaced
XSync(drw->dpy, False)withXFlush(drw->dpy)indrw_map(drw.c).🎯 Why:
XSyncforces a round-trip to the X server, blocking the client until the server processes the request. This causes unnecessary latency during frequent drawing operations like status bar updates.XFlushsends the requests without waiting, which is sufficient because X11 guarantees request ordering.📊 Impact: Reduces client-side latency during redraws, making the UI feel more responsive.
🔬 Measurement: Verified by compiling with
make clean && make. No regressions in build.PR created automatically by Jules for task 7729798404192147833 started by @paperbenni