feat: implement single-statement if-block wrapping #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content handling to use `Cow`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the wrap_single_statement_if feature, allowing single-statement if and else blocks to be automatically wrapped in begin...end blocks while maintaining correct logical line structure and indentation.
Key Changes
Configuration: Added wrap_single_statement_if setting to FormattingConfig.
Parser Refactor: Completely refactored wrap_if_blocks in parser.rs to perform physical logical line splitting for injected begin and end tokens.
Indentation Logic: Synchronized parent/level assignments to ensure injected blocks match pasfmt native indentation (aligning begin/end with the control statement).
Core Improvements: Added set_level and set_parent methods to LogicalLine in lang.rs to support dynamic restructuring.
Tests: Expanded unit tests in if_wrap_tests.rs and updated integration test data.
this was created using vibe coding and gemini 3, and tested in a one million lines of legacy project.