Skip to content

Team reviewers exclusions #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixlut wants to merge 5 commits into from
Closed

Team reviewers exclusions #1965

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a09dbdf
add option to exclude list of users from team PR reviews
felixlut Oct 15, 2023
390fd25
Merge branch 'integrations:main' into team-reviewers-exclusions
felixlut Oct 17, 2023
bda8a74
updateteamreviewassignmentinput takes the node_id, not the id
felixlut Oct 17, 2023
cd09dcc
Merge branch 'main' into team-reviewers-exclusions
felixlut Oct 27, 2023
7676f53
Merge branch 'main' into team-reviewers-exclusions
felixlut Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions github/resource_github_team_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,15 @@ func resourceGithubTeamSettings() *schema.Resource {
Default: false,
Description: "whether to notify the entire team when at least one member is also assigned to the pull request.",
},
// TODO: The underlying graphql call is using memberIds. Might be better UX to use usernames, or add both as an option...
"excluded_team_member_node_ids": {
Type: schema.TypeSet,
Optional: true,
Description: "A list of users to exclude from the PR review process",
Elem: &schema.Schema{
Type: schema.TypeString,
},
},
},
},
},
Expand Down Expand Up @@ -152,6 +161,7 @@ func resourceGithubTeamSettingsRead(d *schema.ResourceData, meta interface{}) er
return err
}
}
// TODO: The exlusion list is not available via the GraphQL call yet (https://docs.github.com/en/enterprise-cloud@latest/graphql/overview/schema-previews#team-review-assignments-preview). Leaving that for future implementation

return nil

Expand Down Expand Up @@ -179,12 +189,20 @@ func resourceGithubTeamSettingsUpdate(d *schema.ResourceData, meta interface{})
} `graphql:"updateTeamReviewAssignment(input:$input)"`
}

exclusionList := make([]string, 0)
for _, v := range settings["excluded_team_member_node_ids"].(*schema.Set).List() {
if v != nil {
exclusionList = append(exclusionList, v.(string))
}
}

return graphql.Mutate(ctx, &mutation, UpdateTeamReviewAssignmentInput{
TeamID: d.Id(),
ReviewRequestDelegation: true,
ReviewRequestDelegationAlgorithm: settings["algorithm"].(string),
ReviewRequestDelegationCount: settings["member_count"].(int),
ReviewRequestDelegationNotifyAll: settings["notify"].(bool),
TeamID: d.Id(),
ReviewRequestDelegation: true,
ReviewRequestDelegationAlgorithm: settings["algorithm"].(string),
ReviewRequestDelegationCount: settings["member_count"].(int),
ReviewRequestDelegationNotifyAll: settings["notify"].(bool),
ReviewRequestexcludedTeamMemberIds: exclusionList,
}, nil)
}
}
Expand Down Expand Up @@ -256,12 +274,13 @@ func resolveTeamIDs(idOrSlug string, meta *Owner, ctx context.Context) (nodeId s
}

type UpdateTeamReviewAssignmentInput struct {
ClientMutationID string `json:"clientMutationId,omitempty"`
TeamID string `graphql:"id" json:"id"`
ReviewRequestDelegation bool `graphql:"enabled" json:"enabled"`
ReviewRequestDelegationAlgorithm string `graphql:"algorithm" json:"algorithm"`
ReviewRequestDelegationCount int `graphql:"teamMemberCount" json:"teamMemberCount"`
ReviewRequestDelegationNotifyAll bool `graphql:"notifyTeam" json:"notifyTeam"`
ClientMutationID string `json:"clientMutationId,omitempty"`
TeamID string `graphql:"id" json:"id"`
ReviewRequestDelegation bool `graphql:"enabled" json:"enabled"`
ReviewRequestDelegationAlgorithm string `graphql:"algorithm" json:"algorithm"`
ReviewRequestDelegationCount int `graphql:"teamMemberCount" json:"teamMemberCount"`
ReviewRequestDelegationNotifyAll bool `graphql:"notifyTeam" json:"notifyTeam"`
ReviewRequestexcludedTeamMemberIds []string `graphql:"excludedTeamMemberIds" json:"excludedTeamMemberIds"`
}

func defaultTeamReviewAssignmentSettings(id string) UpdateTeamReviewAssignmentInput {
Expand Down