feat: add github_user_ssh_signing_key

[simonostendorf]

Resolves #2365

Resolves #1917

---

Before the change?

• managing ssh signing keys was not possible

After the change?

• managing ssh signing keys is possible with github_user_ssh_signing_key resource
• the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[kfcampbell]

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

[simonostendorf]

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

[quotidian-ennui]

#1917 should perhaps be formally linked to this PR as well since it appears equivalent to #2365

[simonostendorf]

@kfcampbell hey, can we get this merged?

[kilianpaquier]

Would love to see this merged

[deiga]

Hey @simonostendorf
Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

• Use Contex-aware functions: [MAINT] Migrate all resources and data sources to Context-aware CRUD functions #2996
• Use tflog for logging: [MAINT] Tracking issue for refactoring logging to use tflog instead of log #3070
• Adhere to new testing structure

[simonostendorf]

Hey @simonostendorf Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

• Use Contex-aware functions: [MAINT] Migrate all resources and data sources to Context-aware CRUD functions #2996
• Use tflog for logging: [MAINT] Tracking issue for refactoring logging to use tflog instead of log #3070
• Adhere to new testing structure

Should be implemented now

[stevehipwell]

Thanks for the PR @simonostendorf. I've added some review comments. Could you also add an import method. And ideally the existing SSH key resource should be aligned with this implementation (off the top of my head - migration to add key_id, code changes, and deprecation of url).

[simonostendorf]

How can I update the website? When I run make website terraform-website downloads and fails because a unknown makefile target is called.

[stevehipwell]

How can I update the website? When I run make website terraform-website downloads and fails because a unknown makefile target is called.

@simonostendorf you just manually modify the website files, check some previous PRs to see how it was done.

[simonostendorf]

Everything should be fixed now (hopefully) :D

[stevehipwell]

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

[simonostendorf]

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

@stevehipwell fixed :)

[stevehipwell]

@simonostendorf could you please fix the lint errors.

[simonostendorf]

@simonostendorf could you please fix the lint errors.

Should be fixed now :)

[stevehipwell]

@simonostendorf please take a look at the sweep failure.

[simonostendorf]

@simonostendorf please take a look at the sweep failure.

@stevehipwell Got the wrong package as import in my test file and therefore the sweep redefined error occured. Should be fixed now "make test" runs fine locally.