-
Notifications
You must be signed in to change notification settings - Fork 933
Add public field to repository pages #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BartolottiLuca
wants to merge
22
commits into
integrations:main
Choose a base branch
from
BartolottiLuca:repository-page-visibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
891a05c
Add public field to github pages
BartolottiLuca 3dbe170
Merge pull request #1 from BartolottiLuca/repository-page-visibility
BartolottiLuca 50725b5
Add public field to repository pages
BartolottiLuca c4b0fd3
add test and creation case
BartolottiLuca b590cd4
Update website/docs/r/repository.html.markdown
BartolottiLuca 508035f
Merge branch 'main' into repository-page-visibility
BartolottiLuca bfeb23d
Merge branch 'main' into repository-page-visibility
BartolottiLuca 17a2703
Merge branch 'main' into repository-page-visibility
BartolottiLuca abe0d9b
Update repository.html.markdown
BartolottiLuca 5ae691a
Merge branch 'integrations:main' into main
BartolottiLuca 3209324
Merge branch 'main' into repository-page-visibility
BartolottiLuca ca85b87
Update github/resource_github_repository.go
BartolottiLuca 1c821b2
make status computed & remove unnecessary change
BartolottiLuca aba7639
Merge branch 'main' into repository-page-visibility
BartolottiLuca 1461e99
Apply suggestion from @deiga
BartolottiLuca ffa8f54
Apply suggestion from @deiga
BartolottiLuca cd7bb22
new test convention and use testResourcePrefix
BartolottiLuca 622a6ec
Merge branch 'integrations:main' into repository-page-visibility
BartolottiLuca 9bfa849
Merge branch 'main' into repository-page-visibility
BartolottiLuca 4c23d8f
Merge branch 'integrations:main' into main
BartolottiLuca 310fd83
Merge branch 'main' into repository-page-visibility
BartolottiLuca 94f32d5
apply suggestions
BartolottiLuca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: This doesn't seem to get set anywhere and in the docs you write that it's optional. Did you mean to use
Optionalhere? Should it haveDefault: falseas well to remove the need for type-checking this later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure which is the best option here. From the docs
So there's no clear default since:
I guess
Computed: trueis safer?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that does look problematic. I think that having only
Computed: trueprevents users from setting the value, which would be unwelcome for GHEC non-EMU cases.Maybe you could check if the SDK sends the field or it's left blank, otherwise the Create and Update need to ensure it's not being sent unless explicitly set.
You're right that Default isn't a good idea, but I guess it needs to be Computed & Optional