This repository was archived by the owner on Jan 7, 2023. It is now read-only.
Open
Conversation
Signed-off-by: root <shianx.a.shao@intel.com>
xuechendi
reviewed
May 4, 2017
analyzer/analyzer.py
Outdated
| summary_data_dict = output_sort["ceph"][table] | ||
| total_data_dict["summary"] = summary_data_dict | ||
| total_data_dict["detail"] = detail_data_dict | ||
| output_sort["ceph"][table] = total_data_dict |
Contributor
There was a problem hiding this comment.
can you move this part into process_sar function?
Contributor
There was a problem hiding this comment.
For current design, I don't think you need to add such logic under format_result_for_visualizer(self, data), you can move to the function to process sar data?
xuechendi
reviewed
May 4, 2017
visualizer/visualizer.py
Outdated
| chart_data[key][node] = value | ||
| output.extend( self.generate_table_from_json(data,'cetune_table', field_type) ) | ||
| output.extend( self.generate_line_chart(chart_data, node_type, field_type ) ) | ||
| if node_type == "ceph": |
Contributor
There was a problem hiding this comment.
Don't make this feature only for 'ceph', please make it more general
xuechendi
reviewed
May 4, 2017
visualizer/visualizer.py
Outdated
| for node, node_data in field_data["detail"].items(): | ||
| if node not in detail_data: | ||
| detail_data[node] = OrderedDict() | ||
| for key, value in node_data.items(): |
Contributor
There was a problem hiding this comment.
this part of codes is duplicated with summary, can you merge it? Or make it as one function？
Signed-off-by: root <shianx.a.shao@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: root shianx.a.shao@intel.com