Active manager is required as Ceph upgrades.

[ningli16]

Active manager is required as Ceph upgrades. Also fix a bug when calls translate_to_id() function.

Signed-off-by: Li Ning ning.li@intel.com

[ningli16]

If not manager is not active, Ceph health will report health_warn

[xuechendi]

Can you add a check here, something like if active mgr no exists, then create?
The creation part looks perfect to me

[ningli16]

Ok. let me add it. Best Regards, Ning From: Chendi.Xue [mailto:notifications@github.com] Sent: Friday, June 15, 2018 10:25 AM To: 01org/CeTune <CeTune@noreply.github.com> Cc: Li, Ning <ning.li@intel.com>; Author <author@noreply.github.com> Subject: Re: [01org/CeTune] Active manager is required as Ceph upgrades. (#298) @xuechendi commented on this pull request.

________________________________ In deploy/mod/deploy.py<#298 (comment)>:

@@ -917,11 +917,8 @@ def start_mgr(self, force=False):

formatted_outStr = common.format_pdsh_return(outStr) ceph_status = formatted_outStr[head] #outList = [x.strip() for x in outStr.split('\n')] - if "no active mgr" in outStr: - common.pdsh(user, [head], "ceph auth get-or-create mgr.admin mon 'allow *' && ceph-mgr -i %s" % ceph_status["fsid"], option="console") - common.printout("LOG", "create mgr success: admin") - else: - common.printout("LOG", "not need create mgr") + common.pdsh(user, [head], "ceph auth get-or-create mgr.$name mon 'allow profile mgr' osd 'allow *' mds 'allow *' && ceph-mgr -i %s" % ceph_status["fsid"], option="console") Can you add a check here, something like if active mgr no exists, then create? The creation part looks perfect to me — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#298 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AUP9FPSsy9pX0ruPeoujl9QiR75KHhGxks5t8xr5gaJpZM4Uo7JA>.