Improvements to symbol resolutions by JonatanWaern · Pull Request #189 · intel/dml-language-server

JonatanWaern · 2026-01-19T15:22:28Z

Drastically improves semantical analysis of methods, supporting various things
that were previously broken.

Also makes an attempt at formalizing he behavior of the various goto-modes and
ensuring, or at least documenting, when these do not work as expected.

Report ambiguous overrides
Refactor ReferenceMatches
Change debug level of some prints
Rework symbol methodology for methods
Rework how fp-based symbol lookup works
Rework how abstract methods and template methods work
Clarify and ensure behavior of goto- operations

JonatanWaern · 2026-01-19T15:33:36Z

@TSonono @lwaern-intel @mandolaerik Have a peek over the addition to USAGE.md to see if these are useful semantics for symbol lookups, and if something is unclear or needs to be specified further. (you can ignore the TODOS for now, hopefully I can resolve those)

JonatanWaern · 2026-02-09T09:06:41Z

@copilot

Copilot · 2026-02-09T09:06:50Z

@JonatanWaern I've opened a new pull request, #192, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

This PR improves semantic analysis and symbol resolution, especially around method overrides/default calls, and formalizes/document goto-* behaviors.

Changes:

Reworked method/trait symbol modeling (abstract vs concrete, default-call tracking, override resolution).
Introduced a dedicated semantic lookup module to centralize goto-definition/declaration/implementation/references behavior.
Improved reference/symbol bookkeeping (template instantiations, in each provenance) and lowered log noise (debug → trace).

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
src/span/mod.rs	Tightens span containment checks to ensure file matches when testing positions.
src/server/mod.rs	Reduces log verbosity for message handling by moving several debug logs to trace.
src/file_management.rs	Reduces log verbosity for path resolution output by moving debug to trace.
src/analysis/templating/traits.rs	Major trait/method refactor: separates abstract vs concrete methods, adds default-call references, updates override/ambiguity handling.
src/analysis/templating/topology.rs	Improves dependency diagnostics (in-each missing template reporting and clearer import mapping log).
src/analysis/templating/objects.rs	Tracks `in each` locations used by composite objects; reworks method override sorting/default-call modeling to match new method ref shape.
src/analysis/templating/methods.rs	Refactors `DMLMethodRef` into a struct, adds `DefaultCallReference`, and extends override validation (shared/default semantics).
src/analysis/symbols.rs	Extends symbol source modeling for per-object method symbols; changes implementations collection to a set; adds compact debug info.
src/analysis/structure/objects.rs	Adds `InEach.loc` and marks empty-body methods as abstract via `MaybeAbstract`.
src/analysis/scope.rs	Reduces log verbosity during reference lookup traversal (debug → trace) and clarifies one debug message.
src/analysis/reference.rs	Refactors `Reference` into `{ variant, extra_info }` to carry additional metadata (e.g., instantiation markers).
src/analysis/provisionals.rs	Adds provisional flag parsing for `explicit_method_decls` plus a unit test.
src/analysis/parsing/structure.rs	Adds parsing support for an optional colon token in methods; marks template instantiation references.
src/analysis/parsing/parser.rs	Reduces parse-context log verbosity (debug → trace).
src/analysis/mod.rs	Large semantic lookup/symbol binding changes: per-parent method symbol indexing, reference matching redesign, method implementation binding, template instantiation implementations.
src/actions/semantic_lookup.rs	New module centralizing semantic symbol/reference lookup and goto-* behaviors with limitation reporting.
src/actions/requests.rs	Switches goto-* requests to use the new semantic lookup APIs, removing duplicated lookup logic.
src/actions/mod.rs	Exposes the new `semantic_lookup` module and lowers wait-state logs (debug → trace).
src/actions/hover.rs	Lowers hover logging verbosity (debug → trace).
src/actions/analysis_storage.rs	Removes unused lookup helpers and lowers storage logs (debug → trace) in a few places.
src/actions/analysis_queue.rs	Lowers queue logging verbosity (debug → trace) and tweaks one linter failure log level.
USAGE.md	Adds documentation clarifying goto-* semantics by symbol kind.
CHANGELOG.md	Documents new behavior around ambiguous default calls, instantiations, and object/template implementations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/analysis/templating/traits.rs

src/analysis/mod.rs

src/actions/semantic_lookup.rs

USAGE.md

CHANGELOG.md

src/analysis/templating/traits.rs

src/analysis/mod.rs

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/analysis/templating/objects.rs

src/analysis/mod.rs

USAGE.md

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/actions/semantic_lookup.rs

Copilot · 2026-02-20T13:34:24Z

src/analysis/templating/topology.rs

+                                        span: *span,
+                                        description: format!(
+                                            "No template; '{}'",
+                                            missing_template_name),
+                                        related: vec![],


The diagnostic text "No template; '{}'" reads like it has an accidental semicolon and is a bit unclear. Consider changing it to something like "No template named '{}'" (or similar), since this is user-facing.

Copilot · 2026-02-20T13:34:24Z

CHANGELOG.md

 ## 0.9.15
 - Added support for line length and breaking rules regarding line-breaks after opening parentheses, method output arguments, conditional expressions and binary operands.
- Added support for indendation rule indent_continuation_line.
+- Added support for indendation rule indent\_continuation\_line.


Spelling: indendation should be indentation.

Willfix in different PR

src/analysis/templating/objects.rs

Copilot · 2026-02-20T13:34:25Z

src/analysis/templating/objects.rs

 //  © 2024 Intel Corporation
 //  SPDX-License-Identifier: Apache-2.0 and MIT
 use std::collections::{HashMap, HashSet};
+use std::hash::Hash;


use std::hash::Hash; appears unused in this module. Please remove it to avoid unused-import warnings (and potential CI failures if warnings are treated as errors).

Suggested change

use std::hash::Hash;

Curious but correct. I think the 'Hash' name is included by default?

src/analysis/mod.rs

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Allows better control of what is _semantically_ matched and what messages are reported to the user Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Ditch the structural lookup, just iterate over all symbols and grab the ones that match Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

- Previously, goto-x at the start of a name would not work, while goto-x at the end or middle of it would. - If there is no definition for a lookup, fall-back to declaration Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

This can happen when methods are ambigiously overridden or overridden in a diamond shape. we will correctly search the entire hierarchy until we find the method from whence the reference came, but we will also search through adjacent hierarchies, so reaching the bottom of those is not actually an unexpected error Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Values in the decl_map can be duplicated when two diamond inheritance occurs. So the prior assumption does not hold (and we do not need it) Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Previously, we used the context-chain as the authorative hierarchical location of the lookup, this does not hold in general (breaks for templates and in-eachs). New approach uses context-chain to find the object from within the reference is made, and then parent-links to search parent scopes Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/analysis/mod.rs

CHANGELOG.md

src/analysis/templating/objects.rs

TSonono

I've tested the implementation in my daily work, and appreciate the improvements!

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

JonatanWaern requested review from TSonono, lwaern-intel and mandolaerik January 19, 2026 15:30

JonatanWaern marked this pull request as ready for review January 26, 2026 09:31

JonatanWaern mentioned this pull request Jan 26, 2026

Method goto-reference fails in some cases #170

Open

JonatanWaern force-pushed the support-prov-explicit-method-decls branch 2 times, most recently from 9cd6ea3 to 74b7ed7 Compare January 30, 2026 13:39

JonatanWaern mentioned this pull request Jan 30, 2026

Late-shared method declarations are not correctly handled #136

Open

JonatanWaern force-pushed the support-prov-explicit-method-decls branch from 4b63018 to e5178c2 Compare February 6, 2026 15:22

Copilot AI mentioned this pull request Feb 9, 2026

[WIP] Improve symbol resolutions for semantical analysis #192

Closed

JonatanWaern requested a review from Copilot February 9, 2026 09:22

Copilot AI reviewed Feb 9, 2026

View reviewed changes

JonatanWaern force-pushed the support-prov-explicit-method-decls branch 2 times, most recently from d5023cc to ddeea49 Compare February 9, 2026 11:10

JonatanWaern requested a review from Copilot February 9, 2026 11:52

Copilot AI reviewed Feb 9, 2026

View reviewed changes

src/analysis/templating/objects.rs Show resolved Hide resolved

src/analysis/mod.rs Show resolved Hide resolved

USAGE.md Outdated Show resolved Hide resolved

JonatanWaern force-pushed the support-prov-explicit-method-decls branch from ddeea49 to 431fa2e Compare February 9, 2026 12:03

JonatanWaern force-pushed the support-prov-explicit-method-decls branch from 2d4ffaf to 008c675 Compare February 16, 2026 12:35

JonatanWaern requested a review from Copilot February 20, 2026 13:28

Copilot started reviewing on behalf of JonatanWaern February 20, 2026 13:29 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

JonatanWaern force-pushed the support-prov-explicit-method-decls branch from 27223ab to 3606d50 Compare February 23, 2026 09:24

JonatanWaern added 5 commits February 24, 2026 10:58

Report ambiguous overrides

c80e21f

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Refactor ReferenceMatches

fbf2505

Allows better control of what is _semantically_ matched and what messages are reported to the user Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Change debug level of some prints

5dbcfa4

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Rework symbol methodology for methods

dc1c3ba

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Rework how fp-based symbol lookup works

a0566de

Ditch the structural lookup, just iterate over all symbols and grab the ones that match Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

JonatanWaern added 21 commits February 24, 2026 10:59

Fix symbol binding around indirect method overrides

2762dc1

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Fix inconsistencies in lookups

6b9fa2d

- Previously, goto-x at the start of a name would not work, while goto-x at the end or middle of it would. - If there is no definition for a lookup, fall-back to declaration Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Add explicit method decl provisional

4f81075

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Correctly report missing templates in in-each

81e8dd0

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Only bind implementations between methods within the same object

5b87832

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Bind implementations on object symbols to in-eachs that apply to them

b0d2353

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Fix bug in goto-decl on parameters

96e9b8d

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Do not return abstract method declaration in goto-impl

6985f56

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Use .identity() to index defined_methods consistently

e8bac52

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Optimize lookup_symbols slightly

ccbd3a8

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Remove redundant symbol iteration

0802651

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Typo fixes

b280ba5

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Fix bug in get_bases

e3be048

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Allow late-shared default calls

b64de9e

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Don't panic on declaration-only methods

9667708

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Do not warn about double-generating methods

fc1ef16

Values in the decl_map can be duplicated when two diamond inheritance occurs. So the prior assumption does not hold (and we do not need it) Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Verify and preserve implementation variant on abstract methods

41881b4

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Slightly improve missing template message

c3e82ad

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Remove unnecessary import

555a7b9

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Remove unused function

095be61

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

JonatanWaern force-pushed the support-prov-explicit-method-decls branch from 3606d50 to 095be61 Compare February 24, 2026 10:01

JonatanWaern mentioned this pull request Feb 25, 2026

Resolution of symbols that are in a (direct?) parent of instantiator does not work #198

Closed

JonatanWaern requested a review from Copilot February 25, 2026 15:06

Copilot started reviewing on behalf of JonatanWaern February 25, 2026 15:06 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/analysis/mod.rs Outdated Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

src/analysis/templating/objects.rs Show resolved Hide resolved

TSonono approved these changes Feb 26, 2026

View reviewed changes

Remove lingering TODO

b6b690a

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

JonatanWaern merged commit bad38b1 into main Feb 26, 2026
4 checks passed

Conversation

JonatanWaern commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonatanWaern commented Jan 19, 2026

Uh oh!

JonatanWaern commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

JonatanWaern Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

JonatanWaern Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TSonono left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonatanWaern commented Jan 19, 2026 •

edited

Loading

TSonono left a comment •

edited

Loading