Fix double-output of document symbols that are scopes#200
Open
JonatanWaern wants to merge 1 commit intomainfrom
Open
Fix double-output of document symbols that are scopes#200JonatanWaern wants to merge 1 commit intomainfrom
JonatanWaern wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes duplicate reporting in the LSP document symbols output when a symbol is both a “flat” symbol and a scope/context in the internal model.
Changes:
- Added a filter to drop certain
SubSymbol::Simpleentries when they correspond to scope-like kinds that are also emitted asSubSymbol::Context. - Applied the filter when constructing
DocumentSymbol.children. - Documented the fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/actions/requests.rs |
Adds a de-duplication filter for scope-like symbols when building nested document symbols. |
CHANGELOG.md |
Adds a release note about fixing double-reporting in document symbol responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
JonatanWaern
force-pushed
the
fix-document-symbols
branch
from
4706942 to
c48402c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonatan Waern jonatan.waern@intel.com