Prepare for using rust 1.93

[JonatanWaern]

• Update subprocess to 1.0
• Clear some clippy warnings
• Use rust 1.93

[Copilot]

Pull request overview

This PR updates the codebase to build cleanly on Rust 1.93 by adopting newer Option/Result helper APIs, upgrading subprocess to 1.0, and adjusting CI to target Rust 1.93.

Changes:

• Replace many map_or(...) patterns with is_some_and / is_ok_and / is_none_or to address clippy warnings and modernize idioms.
• Upgrade subprocess from =0.2.9 to 1.0 and migrate DFA client process spawning to the new API (Exec/Job).
• Update GitHub Actions workflows to use Rust 1.93.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/server/mod.rs	Uses is_ok_and / is_some_and to modernize checks and reduce clippy noise.
src/main.rs	Removes unused clap imports while keeping derive helper attributes.
src/lsp_data.rs	Updates URI scheme checks and capability checks using is_some_and.
src/dfa/main.rs	Adapts error-code handling to the updated subprocess exit status API.
src/dfa/client.rs	Migrates subprocess spawning from Popen to Exec/Job for subprocess 1.0.
src/analysis/templating/topology.rs	Refactors map_or usage to is_some_and.
src/analysis/templating/objects.rs	Uses is_none_or; adds clippy allow for large_enum_variant.
src/analysis/symbols.rs	Adds clippy allow for large_enum_variant.
src/analysis/structure/objects.rs	Refactors optional token kind checks via is_some_and.
src/analysis/parsing/types.rs	Refactors parser lookahead loops to is_some_and.
src/analysis/parsing/structure.rs	Refactors optional token checks/loops to is_some_and.
src/analysis/parsing/statement.rs	Refactors loop continuation logic and adds clippy allow for large_enum_variant.
src/analysis/parsing/misc.rs	Refactors “empty list” detection using is_some_and.
src/analysis/parsing/expression.rs	Refactors expression parsing lookahead checks via is_some_and.
src/analysis/mod.rs	Refactors shallow/object kind checks and CanonPath comparisons using new helpers.
src/actions/semantic_lookup.rs	Refactors template-implementation presence check to is_some_and.
src/actions/notifications.rs	Refactors JSON object emptiness check via is_some_and.
src/actions/mod.rs	Refactors workspace path check and file watch comparison to is_ok_and / is_some_and.
src/actions/analysis_storage.rs	Refactors many Option/Result defaulting checks via is_none_or/is_ok_and/is_some_and.
Cargo.toml	Bumps subprocess dependency to 1.0.
.github/workflows/scans.yml	Pins Rust version to 1.93.0 and attempts to switch toolchain during runs.
.github/workflows/binaries.yml	Pins Rust version to 1.93.0 for builds/tests/clippy in CI.

Comments suppressed due to low confidence (1)

.github/workflows/binaries.yml:35

• rust_version is updated, but the workflow later uses it with rustup default ${{ env.rust_version }} without ensuring that toolchain is installed. This can break CI on runners that don’t already have that exact version. Add an explicit toolchain install step (or a Rust toolchain setup action) before setting the default.

    rust_version: 1.93.0
jobs:
  build:
    runs-on: ${{ inputs.os }}
    steps:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.