Skip to content

rdt: correct prometheus metric types #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marquiz merged 1 commit into from
Dec 9, 2025
Merged

rdt: correct prometheus metric types #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pkg/rdt/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,22 @@ func (c *collector) collectGroupMetrics(ch chan<- prometheus.Metric, g ResctrlGr
for feature, value := range data {
ch <- prometheus.MustNewConstMetric(
c.describeL3(feature),
prometheus.CounterValue,
promValueTypeL3(feature),
float64(value),
labels...,
)
}
}
}

// promValueTypeL3 returns Prometheus value type for given L3 metric.
func promValueTypeL3(feature string) prometheus.ValueType {
switch feature {
case "llc_occupancy":
return prometheus.GaugeValue
case "mbm_local_bytes", "mbm_total_bytes":
return prometheus.CounterValue
default:
return prometheus.GaugeValue
}
}