Fix bazel run //tools:generate_reserved_tokens#228
Merged
Conversation
Migrate from WORKSPACE to MODULE.bazel for Bazel 8.5.1 compatibility. The token generator was broken due to WORKSPACE deprecation in Bazel 8+. Changes: - Add .bazelversion pinning Bazel 8.5.1 - Replace WORKSPACE with MODULE.bazel using local_path_override for batfish dependency - Add maven extension usage to work around rules_jvm_external lock_file bug when batfish is used as a dependency module - Update tools/BUILD.bazel to reference antlr_grammar rule outputs (batfish changed from exposing individual .tokens files to using antlr_grammar rules that output them) - Update Python import path in generate_reserved_tokens.py for rules_python 1.8.3 - Regenerate default_reserved_words.py with latest batfish tokens ---- Prompt: ``` get bazel run //tools:generate_reserved_tokens working ``` commit-id:e849849c
dhalperi
commented
Feb 5, 2026
Member
Author
dhalperi
left a comment
dhalperi
left a comment
There was a problem hiding this comment.
@dhalperi reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved.
dhalperi
added a commit
that referenced
this pull request
Feb 5, 2026
Migrate from WORKSPACE to MODULE.bazel for Bazel 8.5.1 compatibility. The token generator was broken due to WORKSPACE deprecation in Bazel 8+. Changes: - Add .bazelversion pinning Bazel 8.5.1 - Replace WORKSPACE with MODULE.bazel using local_path_override for batfish dependency - Add maven extension usage to work around rules_jvm_external lock_file bug when batfish is used as a dependency module - Update tools/BUILD.bazel to reference antlr_grammar rule outputs (batfish changed from exposing individual .tokens files to using antlr_grammar rules that output them) - Update Python import path in generate_reserved_tokens.py for rules_python 1.8.3 - Regenerate default_reserved_words.py with latest batfish tokens ---- Prompt: ``` get bazel run //tools:generate_reserved_tokens working ``` commit-id:e849849c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from WORKSPACE to MODULE.bazel for Bazel 8.5.1 compatibility.
The token generator was broken due to WORKSPACE deprecation in Bazel 8+.
Changes:
batfish dependency
bug when batfish is used as a dependency module
(batfish changed from exposing individual .tokens files to using
antlr_grammar rules that output them)
rules_python 1.8.3
Prompt:
This change is