pl-favat-v3: preceding no longer required when it is a credit note#718
Open
pl-favat-v3: preceding no longer required when it is a credit note#718
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the requirement for preceding invoices in credit notes for the Polish FA VAT v3 addon, making them optional instead of mandatory. This aligns with Polish KSeF FA_VAT requirements where credit notes can be issued without referencing a specific preceding invoice.
Changes:
- Removed the validation requirement that credit notes must have preceding invoices in the Polish FA VAT v3 addon
- Updated tests to verify credit notes are valid without preceding invoices
- Documented the change in the CHANGELOG
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| addons/pl/favat/bill.go | Removed the validation.Required constraint on inv.Preceding for credit notes, making preceding invoices optional |
| addons/pl/favat/bill_test.go | Updated test to expect successful validation for credit notes without preceding invoices |
| CHANGELOG.md | Added entry documenting the removal of the preceding requirement for credit notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 92.86% 92.86% -0.01%
==========================================
Files 331 331
Lines 17260 17256 -4
==========================================
- Hits 16029 16025 -4
Misses 867 867
Partials 364 364 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.Only after checking off all the previous items: