Correct historical VAT rates in German regime#751
Open
rilla wants to merge 1 commit intoinvopop:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on #750 I stumbled upon some inaccuracies in historical tax rate definitions for the German regime (the COVID end date seemed to be off by a year and that raised my attention).
I searched the OECD.org database but couldn't find the dataset originally used when this regime was introduced in #221, so I researched authoritative sources and found that the original implementation had wrong dates, wrong rates, and a spurious entry in the reduced rate history.
Changes
Standard rate (Regelsteuersatz)
Reduced rate (ermäßigter Steuersatz)
Sources
Replaced the generic OECD tax database link with three German government sources that directly back the rates defined in the file:
Secondary sources
For a consolidated overview of all historical German VAT rates in one place, see:
Didn't add this to
tax_categories.gosince it's not an official government sourcePre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: