Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 333 333
Lines 17794 17798 +4
=======================================
+ Hits 16558 16562 +4
Misses 870 870
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Spain TicketBAI (es-tbai-v1) addon invoice validation rules so that customer presence and TaxID validation are enforced only for non-simplified invoices, aligning validation behavior with simplified-invoice expectations.
Changes:
- Make
inv.Customerrequired only when the invoice is not taggedtax.TagSimplified, and only then run TicketBAI-specific customer TaxID validation. - Add test cases covering missing customer for standard invoices, and allowing missing customer / missing customer TaxID for simplified invoices.
- Add an Unreleased changelog entry documenting the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| addons/es/tbai/bill.go | Gates customer Required + TicketBAI customer validation behind !inv.HasTags(tax.TagSimplified) |
| addons/es/tbai/bill_test.go | Adds regression/behavior tests for standard vs simplified invoice customer requirements |
| CHANGELOG.md | Documents the validation behavior change under Unreleased/Changed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: