Fixed UserWarning about preferring 'filter' keyword for query.

[lukwam]

UserWarning that this was generating was:

/usr/local/lib/python3.12/site-packages/google/cloud/firestore_v1/base_collection.py:303: UserWarning: Detected filter using positional arguments. Prefer using the 'filter' keyword argument instead.

[joakimnordling]

Thanks for this fix @lukwam!

It looks like commit df8f7194685195f52a31b45e2f0bb171306dc72c is what the PR should be made from and you accidentally then into the same branch merged the stuff from your other PR about the exclude_none and exclude_unset. Do you think you could get the PR updated so that it wouldn't include all the other unrelated changes? If the commit I mentioned just has all the necessary changes (looked to me like it had), simplest solution might be to just reset the branch to that commit and force-push it. You can leave all the changes in the changelog in the Unreleased section (as it was in that commit); I think we might want to either combine your two PRs to one release (will have to check with @fbjorn), but you can leave that fiddling with the release dates and posisble conflicts to the changelog to us to take care of.

[lukwam]

Will fix this PR!

[lukwam]

Would you prefer to do these as two separate PRs or as one? I can add this small fix to the other PR, or we can just rebase this one after the other one is merged.

[joakimnordling]

Would you prefer to do these as two separate PRs or as one? I can add this small fix to the other PR, or we can just rebase this one after the other one is merged.

Preferably two separate, stand alone PRs and preferably so that neither one does any change to the version number in the pyproject.toml and the changes in the Changelog are just in the Unreleased section if I can wish and you have time. But we can work with this as well.

My plan is to still go through your two PRs tomorrow at some point with @fbjorn if I can find a free slot from him (this was the agreed plan at least) and get these merged unless there's anything I have overlooked. Form my side the changes look OK. And especially a big thanks for fixing this filter warning!

[lukwam]

New pr at #80