Skip to content

wikimedia broken logos fix#25998

Merged
BellezaEmporium merged 6 commits intoiptv-org:masterfrom
StrangeDrVN:strange-wiki-logos-fix
Mar 10, 2026
Merged

wikimedia broken logos fix#25998
BellezaEmporium merged 6 commits intoiptv-org:masterfrom
StrangeDrVN:strange-wiki-logos-fix

Conversation

@StrangeDrVN
Copy link
Collaborator

  • Potential fix for wikimedia logos - either won't load or shows Error Use thumbnail steps listed on https://w.wiki/GHai. Please contact noc@wikimedia.org for further information (a765913). changed non-standard px to 960px/500px in the url and width/height accordingly.
image

@StrangeDrVN
Copy link
Collaborator Author

StrangeDrVN commented Mar 9, 2026

#26001 #25936

@StrangeDrVN StrangeDrVN requested a review from Alstruit March 9, 2026 09:45
BellezaEmporium
BellezaEmporium previously approved these changes Mar 9, 2026
@Archrootsda
Copy link
Contributor

Archrootsda commented Mar 9, 2026

Before sending the request, make sure that the number of columns in the file has not changed and that all rows end with CRLF. Otherwise we will not be able to review this request

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#how-to-add-a-new-entry-to-the-database

The last line (40692) requires CRLF
Screenshot from 2026-03-09 15-26-50

@StrangeDrVN
Copy link
Collaborator Author

StrangeDrVN commented Mar 9, 2026

Isn't it already? It shows CRLF in mine.

Before sending the request, make sure that the number of columns in the file has not changed and that all rows end with CRLF. Otherwise we will not be able to review this request

@Archrootsda
Copy link
Contributor

Isn't it already? It shows CRLF in mine.

Before sending the request, make sure that the number of columns in the file has not changed and that all rows end with CRLF. Otherwise we will not be able to review this request

sorry i edited your comment: error
You have to press enter after the last line
Screenshot from 2026-03-09 15-37-16

@Archrootsda
Copy link
Contributor

Archrootsda commented Mar 9, 2026

your file does not have CRLF in the final line
Notepad++ screenshot
Screenshot from 2026-03-09 15-41-28

@StrangeDrVN
Copy link
Collaborator Author

my bad, usually validate rejects new line so had removed it earlier. must be in iptv repo. what about now? else I'll manually upload the file.

your file does not have CRLF in the final line

@StrangeDrVN
Copy link
Collaborator Author

is this relevant? Warning: 26-03-09 14:45:14 [WARNING] No files with crlf endings found.

@Archrootsda
Copy link
Contributor

is this relevant? Warning: 26-03-09 14:45:14 [WARNING] No files with crlf endings found.

the error is common https://github.com/iptv-org/database/actions/runs/22659686326/job/65676857818?pr=25871

Archrootsda
Archrootsda previously approved these changes Mar 9, 2026
@StrangeDrVN StrangeDrVN requested a review from Dum4G March 9, 2026 15:48
@Dum4G
Copy link
Contributor

Dum4G commented Mar 10, 2026

image Is it okay to have non-integer values here? @freearhey

@StrangeDrVN
Copy link
Collaborator Author

I noticed them in a few others, hence kept it. I can round them off though if necessary.

Is it okay to have non-integer values here?

@StrangeDrVN
Copy link
Collaborator Author

StrangeDrVN commented Mar 10, 2026

@Dum4G svg dimensions seems to be rounded off by script calculation. Eg: detected as 487.48 × 146.66 and gets rounded off to 487 x 147.
image

@BellezaEmporium BellezaEmporium merged commit 8253749 into iptv-org:master Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants