Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new commands to the dotfiles management tool for handling zsh shell completions. The completion command generates completions for the dots command itself, while the completions command generates completions for various installed development tools (bat, fnm, gum, jj, mise, rustup/cargo, uv, and zellij).
Changes:
- Added
completioncommand to output the dots command completion definition - Added
completionscommand to automatically generate zsh completions for multiple installed tools - Created new script to generate completions for third-party tools
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config/zsh/completions/_dots | Added completion entries for the new completion and completions commands |
| assets/scripts/main.sh | Implemented generate_completion() and generate_package_completions() functions and their command handlers |
| assets/scripts/completions/generate-zsh-completions.sh | New script to generate zsh completions for bat, fnm, gum, jj, mise, rustup, cargo, uv, and zellij |
| assets/scripts/completions/compdef_dots.zsh | Added completion entries for the new completion and completions commands (mirrors _dots file) |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Description