Conversation
Co-authored-by: irichu <197713379+irichu@users.noreply.github.com>
Co-authored-by: irichu <197713379+irichu@users.noreply.github.com>
Remove unnecessary directory changes in generate-zsh-completions.sh
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an Ubuntu Desktop “autoinstall” configuration and enhances the main installer script with a confirmation prompt (plus minor UX/help text updates).
Changes:
- Add
assets/scripts/desktop/autoinstall.yamlfor unattended Ubuntu Desktop installation/customization. - Add
-y/--yessupport and aconfirm()prompt to gate--ubuntu-desktopinstallations inassets/scripts/main.sh. - Minor updates to GNOME favorites and completion-generation/help output.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/scripts/main.sh | Adds global -y/--yes parsing and a confirmation prompt before --ubuntu-desktop installs; updates usage output. |
| assets/scripts/desktop/set-dconf-custom-desktop.sh | Adds Ghostty to GNOME favorite apps list. |
| assets/scripts/desktop/autoinstall.yaml | Introduces an Ubuntu autoinstall template with identity, storage, apt mirror, ssh keys, and late-commands. |
| assets/scripts/completions/generate-zsh-completions.sh | Removes directory-changing logic while generating zsh completions. |
| README.md | Adjusts the git installation accordion summary text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description