catch processing errors and emit them as events#13
Open
demmer wants to merge 1 commit intoiriscouch:masterfrom
jut-io:handle-processing-errors
Open
catch processing errors and emit them as events#13demmer wants to merge 1 commit intoiriscouch:masterfrom jut-io:handle-processing-errors
demmer wants to merge 1 commit intoiriscouch:masterfrom
jut-io:handle-processing-errors
Conversation
Member
|
Thank you for this PR! Unfortunately, I am no longer a maintainer in this GitHub account, but I have merged your branch in my own fork, https://github.com/jhs/dnsd and I have included it in the v0.9.6 release. |
Author
|
Thanks for the quick turnaround. Will your fork be the authoritative repository for this package going forward in case I have other changes to suggest? I assume so given that you updated the npm metadata as such but I just wanted to be sure. |
Member
|
Yes, my fork is the official one. I started the project when I was in the iriscouch organization however I am no longer there. But I still maintain many of the projects here. I still have npm publish ability, which is the main thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the server received a malformed packet, the request processing would throw an uncaught error which can end up killing the node process.
Instead, add a try ... catch handler around the Request / Response processing and trigger an error event which can be caught and handled gracefully. Include an error message, the actual Error object, and the connection info in the event callback so aid debugging and make it possible to log where the bogus requests are coming from.