This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Update hyper #2
Open
Update hyper #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make consistent formatting using rustfmt.
Move the &mut to the type.
error[E0308]: mismatched types
--> tests/test_serial.rs:11:31
|
11 | async fn test_get_respond_200(&mut ctx: PortContext) {
| ^^^^^^^^
| |
| expected `PortContext`, found `&mut _`
| this expression has type `PortContext`
| help: to declare a mutable variable use: `mut ctx`
|
= note: expected struct `PortContext`
found mutable reference `&mut _`
We're calling an async function, but aren't awaiting it. Let's do that.
warning: non-binding `let` on a future
--> tests/test_serial.rs:62:9
|
62 | let _ = self.http_context.teardown();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
This removes the need for async_trait.
hyper 0.14 is pretty old by now. Update to version 1.
fransklaver
force-pushed
the
update-hyper
branch
from
955f0dc to
3c2368b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyper 0.14 is pretty old. Update to hyper 1.6.