Skip to content

Comments

Fixes for using mercurial-ruby on Windows#8

Open
Tak wants to merge 2 commits intoisabanin:masterfrom
Tak:windows
Open

Fixes for using mercurial-ruby on Windows#8
Tak wants to merge 2 commits intoisabanin:masterfrom
Tak:windows

Conversation

@Tak
Copy link

@Tak Tak commented Apr 11, 2016

I hit two stumbling blocks when trying to use mercurial-ruby on windows:

  • popen4 ultimately calls fork, which is unsupported
  • shell tries to wrap command arguments in single quotes, which the windows shell hates

I've verified that neither change regresses existing tests (open3 codepath passes everything, double-quote codepath passes everything except tests to ensure that we're using single quotes to wrap)

@cignoir
Copy link

cignoir commented Apr 12, 2016

👍
This fixes #6.

@Tak
Copy link
Author

Tak commented Aug 8, 2016

So...is this repo abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants