Conversation
Contributor
|
Thanks for the contribution. Couple of issues: I notice I still need to confirm that the PR does not brake CUDA and CPU compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a separate pipeline to use GPUs on a ROCM environment. This pipeline avoids using gpu-numba, as this has not been updated for ROCM for quite some time. The loading and unloading is a bit hacky, but I haven't noticed too much perfomance degradation.
Passed all pytest tests.
Tested on a node with 8 AMD Instinct MI250X GPU's.
Please note I did not have access to a NVIDIA multi GPU environment, some testing may be warranted.