[pull] dev from KelvinTegelaar:dev #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a simplified Graph Explorer filter and several UI/behavior improvements. Key changes: - Add CippGraphExplorerSimpleFilter component to provide a compact preset selector, Run/Edit Filters toggle, and view-mode switch (table/json). - Update graph-explorer page to use the simple filter, add viewMode state, fetch JSON results for a new JSON editor view, and show loading overlay when fetching. - Enhance CippGraphExplorerFilter: support parent-driven selectedPreset, onPresetSelect callback, hideButtons flag, sync preset selection with parent, refactor footer actions, and minor layout/spacing fixes. - Modify CippOffCanvas: add contentPadding and keepMounted props, apply padding to content container and allow controlling ModalProps.keepMounted. - Update CippButtonCard to hide header/divider when no title is provided. - Update CippCodeBlock to pass code via value and set the editor to readOnly. - Wire CIPPTableToptoolbar to pass selectedPreset/onPresetSelect and off-canvas options (contentPadding, keepMounted). These changes enable a lightweight preset-driven workflow, a JSON view for debugging, better off-canvas behavior, and improved preset synchronization between components.
Replace filter-focused wording and icon with query-focused alternatives in CippGraphExplorerSimpleFilter. Swapped import of FilterList for ManageSearch, updated the button icon and label from "Edit Filters" to "Edit Query", and changed the off-canvas title from "Graph Explorer Filters" to "Graph Explorer Query" to reflect the new terminology.
Replace absolute "/src/..." imports with relative imports and apply minor formatting/cleanup across reusable settings pages and components. Changes include: converting import paths in multiple files (add/edit/index pages and a form component), expanding Material-UI imports to multiline, wrapping long expressions/JSX props for readability, reformatting generateGuid's s4 helper, making several conditional/assignment blocks multiline, and minor button JSX formatting. These are largely non-functional readability and module-path fixes across: - src/components/CippFormPages/CippAddIntuneReusableSettingTemplateForm.jsx - src/pages/endpoint/MEM/reusable-settings-templates/add.jsx - src/pages/endpoint/MEM/reusable-settings-templates/edit.jsx - src/pages/endpoint/MEM/reusable-settings-templates/index.js - src/pages/endpoint/MEM/reusable-settings/edit.jsx - src/pages/endpoint/MEM/reusable-settings/index.js No behavioral changes intended; mainly import path normalization and code style improvements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )