Open
Conversation
Adds a full Resend API fake covering 10 scenarios: email sending lifecycle, scheduled emails, batch sending, domain/contact/template/API key management, webhook configuration, template-email integration, and error handling. 52 contract tests grounded against the real Resend API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Extract sender email from display name format before asserting, avoiding substring check that CodeQL flagged as incomplete URL sanitization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zozo123
reviewed
Mar 4, 2026
| "Missing `subject` field.", | ||
| ) | ||
|
|
||
| # 4. `from` required |
Contributor
There was a problem hiding this comment.
[P1] Template send incorrectly requires from in request.
POST /emails enforces from before applying template defaults, so a request that relies on template from fails with 422 even though template defaults should be usable when request fields are omitted.
zozo123
reviewed
Mar 4, 2026
| if not text: | ||
| return text | ||
|
|
||
| def replace_var(match): |
Contributor
There was a problem hiding this comment.
[P1] Template variables can trigger 500.
_substitute_template_variables returns raw values from variables; if a value is numeric (allowed by Resend), re.sub receives a non-string replacement and the request fails with HTTP 500 instead of a normal API response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.memory/research artifacts for future referenceTest plan
fake_onlydue to free-tier account limits)🤖 Generated with Claude Code