Skip to content

Fixed usage of restic cat config leaving zombies #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itzg merged 1 commit into from
Feb 24, 2026
Merged

Fixed usage of restic cat config leaving zombies #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions scripts/opt/backup-loop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ fi
: "${RESTIC_HOSTNAME:=$(hostname)}"
: "${RESTIC_VERBOSE:=false}"
: "${RESTIC_LIMIT_UPLOAD:=0}"
: "${RESTIC_CAT_CONFIG_TIMEOUT:=10s}"
: "${RESTIC_RETRY_LOCK:=1m}" # Max time restic will retry to acquire a repository lock before failing
: "${XDG_CONFIG_HOME:=/config}" # for rclone's base config path
: "${ONE_SHOT:=false}"
Expand Down Expand Up @@ -466,10 +467,7 @@ restic() {
# Duplicate stdout to a first unused file descriptor (fd) 5 which will be used later
exec 5>&1

# Run restic, prefix each line and redirect output to fd 5 in a subshell (so it can be shown in realtime).
# And finally capture the whole output for later processing
# printf("%s %s %s\n", strftime("%FT%T%z"), level, $0);
if output="$(command restic cat config 2>&1 >/dev/null | stdbuf -oL awk '{printf("%s restic cat config: %s\n", strftime("%FT%T%z"), $0);}' | tee >(cat - >&5))"; then
if output="$(command timeout "${RESTIC_CAT_CONFIG_TIMEOUT}" restic cat config 2>&1 >/dev/null)"; then
log INFO "Repository already initialized"
log INFO "Checking for stale locks"
_unlock
Expand Down