-
Notifications
You must be signed in to change notification settings - Fork 9
Add slash command installation flow #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ivangrynenko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Cursor rules installer by integrating the capability to install a comprehensive set of Cursor slash commands. This feature streamlines developer workflows by providing pre-configured prompts for common tasks, improving efficiency and consistency. The changes include updates to the core installer logic, new command-line options, and a thorough refresh of associated documentation and test coverage to ensure robust functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature: the ability to install curated Cursor slash commands. It adds new CLI options (--commands, --skip-commands) and interactive prompts to the installer, allowing users to install commands to their project, home directory, or both. The changes are well-supported by an expanded test suite that validates the new installation scenarios, including a clever way to test interactive prompts. Documentation has also been updated accordingly, with a new CHANGELOG.md and a more concise spec file. The implementation is robust, handling local command sources for testing and falling back to downloading from GitHub. I've found a few minor issues in the newly added command instruction files, such as a hardcoded local path and a potential typo, which I've commented on.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
--commands/--skip-commandsCLI controls plus interactive prompts for home/project/both targetsTesting