Open
Conversation
Alliance server-side implementation.
Prepare for compile.
A stretch on request and results of Alliances.
Added CRUD for Alliances
Create methods for alliance management.
iw2d
reviewed
Sep 25, 2025
| } | ||
|
|
||
| public static CentralServerNode getCentralServerNode() { | ||
| return centralServerNode; |
Owner
There was a problem hiding this comment.
It may be unintuitive, but we cannot call functions on CentralServerNode directly. Instead, all communications between channel/login/central instances are done via packets so that they may run in separate processes - see ChannelServerHandler.java, LoginServerhandler.java, CentralServerHandler.java.
I will add a task for myself to make some changes so that this is clearer.
Author
There was a problem hiding this comment.
There. Solved the part where the CentralServerNode was not being sent the packets for Alliances.
Made amends with proper packets to CentralServerNode on Alliances instead of calling Server direcly.
Alliance server-side implementation.
Prepare for compile.
A stretch on request and results of Alliances.
Added CRUD for Alliances
Create methods for alliance management.
Made amends with proper packets to CentralServerNode on Alliances instead of calling Server direcly.
MujyKun
reviewed
Dec 20, 2025
| } | ||
|
|
||
| public boolean addGuild(int guildId) { | ||
| if (canAddGuild(guildId)) { |
There was a problem hiding this comment.
inverse logic?
should be if (!canAddGuild(guildId))
MujyKun
reviewed
Dec 20, 2025
| } | ||
|
|
||
| public int getAllianceId() { | ||
| return guildId; |
Conflicts cleared.
Clear inverse logic.
Implement ChangeGrade and Destroy alliances.
Implemented central server node handling for set grade names on alliances.
Implemented central server node handling for update member count for alliances.
Implemented central server node handling for change master in alliances.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the functional methods for Alliances. Missing server-client interaction measures.
Wishful thinking
It's as much of an honor for me to be part of all this prospect for the community of MapleStory. The final objective, enquest to give the users the best potential experience at mapling. I would dedicate all my maple-related work until now to my parents and siblings, whom I cherish dearly. That's it.