-
-
Notifications
You must be signed in to change notification settings - Fork 124
Add GitHub artifact attestations to Docker workflow #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1497 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 87 87
Lines 18154 18154
=======================================
Hits 16611 16611
Misses 1543 1543 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (22.5 MiB → 22.5 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
Adds build provenance attestations for Docker images so consumers can
verify images were built by CI:
gh attestation verify oci://ghcr.io/j178/prek:latest --repo j178/prek
Similar to j178#1494 which added attestations for release artifacts.
Reference: astral-sh/uv#8685
639046d to
aaed56c
Compare
|
@copilot can i request you big dawg or only j178 |
|
@copilot gimme review pretty pls |
|
I set up automatic review with copilot, not sure why it didn’t trigger on this PR… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds GitHub artifact attestations to the Docker build workflow, enabling consumers to verify that Docker images were built by CI. This mirrors the functionality added in PR #1494 for release artifacts and follows the pattern from astral-sh/uv#8685.
Changes:
- Added
attestations: writeandid-token: writepermissions to the build-docker job configuration - Updated the Docker workflow to extract the manifest digest and generate build provenance attestations
- Configured permissions in the release workflow to support attestation generation when calling the Docker build workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dist-workspace.toml | Added attestations and id-token permissions to the build-docker job configuration |
| .github/workflows/release.yml | Added attestations and id-token permissions when calling the build-docker workflow |
| .github/workflows/build-docker.yml | Added steps to export the manifest digest and generate artifact attestations using actions/attest-build-provenance |
It doesn't like me i guess :( |
|
Thank you! |
Adds actions/attest-build-provenance to the Docker build workflow so consumers can verify images were built by CI:
Similar to #1494 which added attestations for release artifacts.
Reference: astral-sh/uv#8685