Add CollectRowsInto to allow custom slice types#2303
Open
ConsoleTVs wants to merge 3 commits intojackc:masterfrom
Open
Add CollectRowsInto to allow custom slice types#2303ConsoleTVs wants to merge 3 commits intojackc:masterfrom
CollectRowsInto to allow custom slice types#2303ConsoleTVs wants to merge 3 commits intojackc:masterfrom
Conversation
CollectRows generic parameters
CollectRows generic parametersCollectRowsInto to allow custom slice types
Owner
|
Do I understand correctly that this is to save a type cast or is it doing more? Without tests its a bit hard to follow the intent. |
Author
|
Oh yes, it's pure type gimmicks, there's no new logic involved. |
Owner
|
As far as I can tell you can do the same by assigning the result of I'm somewhat inclined against adding a public function to save a line of code on the basis of avoiding the increase in API surface unless it was going to be very frequently used. And anyone that is doing that type operation frequently can add this helper function to their project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
CollectRowsIntoto allow overriding the slice type returnedby
CollectRows. This change is backwards compatible.