Skip to content

Add sentinel value for acquire errors #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajeetdsouza wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Add sentinel value for acquire errors #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pgxpool/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package pgxpool

import "errors"

var ErrInfiniteAcquireLoop = errors.New("pgxpool: detected infinite loop acquiring connection; likely bug in PrepareConn or BeforeAcquire hook")
3 changes: 1 addition & 2 deletions pgxpool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package pgxpool

import (
"context"
"errors"
"math/rand/v2"
"runtime"
"strconv"
Expand Down Expand Up @@ -652,7 +651,7 @@ func (p *Pool) Acquire(ctx context.Context) (c *Conn, err error) {

return cr.getConn(p, res), nil
}
return nil, errors.New("pgxpool: detected infinite loop acquiring connection; likely bug in PrepareConn or BeforeAcquire hook")
return nil, ErrInfiniteAcquireLoop
}

// AcquireFunc acquires a *Conn and calls f with that *Conn. ctx will only affect the Acquire. It has no effect on the
Expand Down