Skip to content

perf(trace): optimize traceSingleQuotedString #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
analytically wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

perf(trace): optimize traceSingleQuotedString #2466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pgproto3/trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,15 +397,20 @@ func traceDoubleQuotedString(buf []byte) string {
return `"` + string(buf) + `"`
}

const hexChars = "0123456789abcdef"

// traceSingleQuotedString returns buf as a single-quoted string with non-printable characters hex-escaped. It is
// roughly equivalent to pqTraceOutputNchar in libpq.
func traceSingleQuotedString(buf []byte) string {
sb := &strings.Builder{}
sb.Grow(len(buf)*4 + 2) // worst case: every byte escaped (\xNN) + quotes

sb.WriteByte('\'')
for _, b := range buf {
if b < 32 || b > 126 {
fmt.Fprintf(sb, `\x%x`, b)
sb.WriteString(`\x`)
sb.WriteByte(hexChars[b>>4])
sb.WriteByte(hexChars[b&0x0f])
} else {
sb.WriteByte(b)
}
Expand Down
Loading