docs(RegisterConnConfig): explain alternative usage#2480
Open
AldoFusterTurpin wants to merge 1 commit intojackc:masterfrom
Open
docs(RegisterConnConfig): explain alternative usage#2480AldoFusterTurpin wants to merge 1 commit intojackc:masterfrom
AldoFusterTurpin wants to merge 1 commit intojackc:masterfrom
Conversation
Give an alternative for when we have clients with many short-lived connections, to avoid memory leaks.
Author
|
@jackc (Sorry for the ping) I believe this is pretty straightforward and can help new people using the module 🙂 |
Owner
|
So it would make sense to document and emphasize the usage of However, the warnings in your PR aren't exactly correct. It does not maintain a map of connections, it maintains a map of configs. You should be able to make any number of connections from a single registered conn config. Also, you can unregister them as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The fact that RegisterConnConfig "holds" an internal map that can grow without bound is something that could be stated explicitly.
PR changes
I believe it would be a good idea to explain an alternative for clients with many short-lived connections to many DBs, to avoid memory leaks. Being a bit more explicit and vocal in the comments about how that works will help clients to choose if they really want to use RegisterConnConfig or the alternative shared.
I placed the comment both in
WDYT ?
Thank you!