Open
Conversation
This adds support for the new protocol 3.2 that is available in Postgres 18+. The specific change is that secret keys are now variable length encoded and no longer a fixed uint32. This is to both improve security and to provide room for additional metadata for middleware. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
jackc
reviewed
Feb 11, 2026
pgconn/pgconn_test.go
Outdated
|
|
||
| func TestConnectProtocolVersion32(t *testing.T) { | ||
| t.Parallel() | ||
| config, err := pgconn.ParseConfig(os.Getenv("PGX_TEST_DATABASE") + " max_protocol_version=3.2") |
Owner
There was a problem hiding this comment.
Based on the failures in CI, I think this might need to change to parse the config, then set max protocol version directly on the config struct. I think that string concatenation is yielding an invalid connection string.
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
| t.Parallel() | ||
| config, err := pgconn.ParseConfig(os.Getenv("PGX_TEST_DATABASE")) | ||
| require.NoError(t, err) | ||
| config.MaxProtocolVersion = "3.2" |
There was a problem hiding this comment.
Would it make sense to use a constant instead of a literal?
Then usages could be found easier in IDEs and Agents.
Author
There was a problem hiding this comment.
I haven't done that since I don't see it used for example for ssl mode flags. But I think it's really a project style decision then, more a question for @jackc then I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the new protocol 3.2 that is available in Postgres 18+.
The specific change is that secret keys are now variable length encoded and no longer a fixed uint32. This is to both improve security and to provide room for additional metadata for middleware.
Fixes #2489