Fix BGReader deadlock when stopping background reads#2502
Closed
sergeydobrodey wants to merge 1 commit intojackc:masterfrom
Closed
Fix BGReader deadlock when stopping background reads#2502sergeydobrodey wants to merge 1 commit intojackc:masterfrom
sergeydobrodey wants to merge 1 commit intojackc:masterfrom
Conversation
Owner
|
I think a race condition would be possible with this change.
In practice, this shouldn't happen, both because we don't call |
Author
|
Agree. I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BGReader.Read could block forever if Stop() was called while the background goroutine was stuck in a read.
Read now falls back to direct reading when status is StatusStopping, not just StatusStopped.
Adds a unit test that reproduces the deadlock and verifies the fix.
Tests
go test ./pgconn/internal/bgreader -run TestBGReaderReadDoesNotWaitWhenStopping
Possible it's a fix for #2119