Use oauth2 1.3.1 or lower#12
Open
siegy22 wants to merge 1 commit intojackdempsey:masterfrom
siegy22:master
Open
Use oauth2 1.3.1 or lower#12siegy22 wants to merge 1 commit intojackdempsey:masterfrom siegy22:master
siegy22 wants to merge 1 commit intojackdempsey:masterfrom
siegy22:master
Conversation
Currently there's an issue when using a higher version of oauth2 than 1.3.1. See #10. When this issue is resolved, this can be set to a higher version again, but until then, let's keep this to the version where it still works.
|
Here's the github issue that talks about this omniauth-oauth2 bug: |
|
This isn't the correct solution to this bug the Updates devs are not going to change the behavior anytime at all.. So the correct fix is to simply implement an overridden callback_url method in the strategy that does the old behaviour. def callback_url
full_host + script_name + callback_path
end |
rosalinekarr
added a commit
to rosalinekarr/omniauth-reddit
that referenced
this pull request
Jan 14, 2018
I added a `callback_url` method to the strategy to fix [this known issue](jackdempsey#12) in OAuth2.
rosalinekarr
added a commit
to rosalinekarr/omniauth-reddit
that referenced
this pull request
Jan 14, 2018
I added a `callback_url` method to the strategy to fix [this known issue](jackdempsey#12) in OAuth2.
faber
added a commit
to 1bios/omniauth-withings
that referenced
this pull request
Apr 9, 2020
faber
added a commit
to 1bios/omniauth-shine
that referenced
this pull request
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's an issue when using a higher version of oauth2 than
1.3.1. See #10.
When this issue is resolved, this can be set to a higher version
again, but until then, let's keep this to the version where it still works.