Refactor alias handling: simplify detection logic and reduce allocations#23
Draft
Copilot wants to merge 2 commits intoclaude/plan-key-alias-support-01Q8Q1qANjKGsL4x1iy4JpfJfrom
Draft
Conversation
- Simplify standalone keysym detection: use forward-compatible check (is next token - or +?) - Create single visited list for entire hotkey parsing instead of multiple times - Rename is_standalone_keysym to key_parsed for clearer semantics - Reduce code duplication and complexity Co-authored-by: jackielii <360983+jackielii@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Restructure PR for key alias support based on review feedback
Refactor alias handling: simplify detection logic and reduce allocations
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures alias handling in
parse_hotkeyto address code review feedback on #21 requesting better high-level structure.Changes
Forward-compatible standalone detection: Replace exhaustive token enumeration (
Token_Command | Token_Forward | Token_BeginList | ...) withnext_token == Token_Dash || next_token == Token_Plus. Alias is standalone unless followed by-or+.Single visited list: Create once per hotkey, reuse with
clearRetainingCapacity()instead of creating/destroying 3+ times per parse.Clearer semantics: Rename
is_standalone_keysym→key_parsedto reflect what it actually tracks (key already determined, not alias type).Before/After
Net: -5 lines, clearer logic, fewer allocations.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.